-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding workflow files for checking for Copyright headers. #38
Conversation
It seems that the spdx check failed in this pipeline. Can you please check whether we need spdx headers in these files: |
For Third Party files see #40 for the empty init files I have submitted a PR in the enarx/ repo: enarx/spdx#22 |
Empty files will now be ignored by the checker. |
@nvukobratTT PTAL if you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for pushing this further!
@vmilosevic can you confirm if config files are optimal? Are there some improvements you would suggest? If not, please approve this PR as well.
@vmilosevic Can you PTAL at this from a workflow POV to make sure it's compatible with what you had in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Adding the spdx / copyright workflow changes based off the ones we have in tt-mlir. Is there a way to check if these run as expected?